Date: Wed, 28 Jan 2004 14:49:31 -0700 (MST) From: Scott Long <scottl@freebsd.org> To: Ruslan Ermilov <ru@FreeBSD.org> Cc: David O'Brien <obrien@FreeBSD.org> Subject: Re: cvs commit: src/sbin/disklabel Makefile disklabel.5 disklabel.8 disklabel.c pathnames.h Message-ID: <20040128144715.C11120@pooker.samsco.home> In-Reply-To: <20040128203513.GD11253@FreeBSD.org.ua> References: <200401281929.i0SJTGIP043858@repoman.freebsd.org> <20040128202822.GA77881@dragon.nuxi.com> <20040128203513.GD11253@FreeBSD.org.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 28 Jan 2004, Ruslan Ermilov wrote:
> On Wed, Jan 28, 2004 at 12:28:22PM -0800, David O'Brien wrote:
> > On Wed, Jan 28, 2004 at 10:19:28PM +0200, Ruslan Ermilov wrote:
> > > Index: Makefile
> > > ===================================================================
> > > RCS file: /home/ncvs/src/sbin/bsdlabel/Makefile,v
> > > retrieving revision 1.19
> > > diff -u -r1.19 Makefile
> > ...
> > > +afterinstall:
> > > +.if exists(${DESTDIR}${BINDIR}/disklabel)
> > > + rm -f ${DESTDIR}${BINDIR}/disklabel
> > > +.endif
> >
> > This is wrong -- ${BINDIR}/disklabel is a link to {bsd,sun}label.
> >
> Perhaps you didn't notice that, but the trimmed part of the patch
> also removes the compatibility link from disklabel to bsdlabel.
>
> The disklabel is not linked to sunlabel since 2003/04/23.
>
Do not remove the compatibility link. We can debate whether or not it
should point to sunlabel (I think that it should, on the appropriate
ARCH), but it should not be removed.
Scott
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040128144715.C11120>