Date: Tue, 17 Oct 2006 02:50:23 GMT From: Bruce Evans <bde@zeta.org.au> To: freebsd-bugs@FreeBSD.org Subject: Re: kern/104436: [PATCH] sys/sem.h should include sys/types.h Message-ID: <200610170250.k9H2oNuF017377@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/104436; it has been noted by GNATS.
From: Bruce Evans <bde@zeta.org.au>
To: Cheng-Lung Sung <clsung@freebsd.org>
Cc: John Baldwin <jhb@freebsd.org>, freebsd-hackers@freebsd.org,
freebsd-current@freebsd.org, freebsd-bugs@freebsd.org,
FreeBSD-gnats-submit@freebsd.org
Subject: Re: kern/104436: [PATCH] sys/sem.h should include sys/types.h
Date: Tue, 17 Oct 2006 12:41:04 +1000 (EST)
On Tue, 17 Oct 2006, Cheng-Lung Sung wrote:
> On Mon, Oct 16, 2006 at 02:31:24PM -0400, John Baldwin wrote:
>> Is this better?
>> ...
> Thanks, I didn't go through the whole sem.h.
> Also, it seems we should put these parts before 'sturct semid_ds'.
> or say, after we include sys/ipc.h (which include sys/_types.h)
Yes, that is especially needed for time_t, since it is the only one of
the typedef'ed types used early in sys/sem.h. The others might be needed
later when the non-typedefed types are cleaned up. (sys/ipc.h needs
cleaning up more. It still spells uid_t as "unsigned short", but uids
aren't that short...)
Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200610170250.k9H2oNuF017377>