Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 16 Jul 1995 13:39:05 +0200 (MET DST)
From:      J Wunsch <j@uriah.heep.sax.de>
To:        tweten@frihet.com
Cc:        joerg_wunsch@uriah.heep.sax.de, info@cdrom.com, hahn@and.com, bugs@freebsd.org
Subject:   Re: CDROM Reading "errors"
Message-ID:  <199507161139.NAA18993@uriah.heep.sax.de>
In-Reply-To: <199507161114.EAA02268@tale.frihet.com> from "David E. Tweten" at Jul 16, 95 04:14:58 am

next in thread | previous in thread | raw e-mail | index | archive | help
As David E. Tweten wrote:
> 
> Joerg Wunsch wrote:
> > Is the CD unreadable, or is it just that the printf's are annoying?
> 
> CD reads seem to work in spite of the flood of syslog messages, though my 
> testing isn't exhaustive.  I can trash the printfs, but it struck me as odd 
> that this sort of thing has never been a problem reading any other Rock Ridge 
> CDs.  The two Walnut Creek CDs (Linux and FreeBSD 2.0.5) are the first, and so 
> far only CDs to have the problem.

They seem to be ignored now.

This is the 1.1 code:

/*
 * Flag indicating
 *   Nothing to do....
 */
static int isofs_rrip_idflag( p, ana )
ISO_RRIP_IDFLAG  *p;
ISO_RRIP_ANALYZE *ana;
{
        char   buf[3];

        buf[0] = p->h.type[0];
        buf[1] = p->h.type[1];
        buf[2]  = 0x00;

        printf("isofs:%s[%d] idflag=0x%x\n",
                                buf,
                                isonum_711(p->h.length),
                                p->flags );
        return 0;
}

...and this is from 2.2-current:

/*
 * Flag indicating
 */
static int
cd9660_rrip_idflag(p,ana)
        ISO_RRIP_IDFLAG *p;
        ISO_RRIP_ANALYZE *ana;
{
        ana->fields &= isonum_711(p->flags)|~0xff; /* don't touch high bits */
        /* special handling of RE field */
        if (ana->fields&ISO_SUSP_RELDIR)
                return cd9660_rrip_reldir(p,ana);

        return ISO_SUSP_IDFLAG;
}

(Relocated directories seem to be handled in another piece of code in
1.1, or there's simply a bug.)

Note that there are a few more ``Nothing to do...'' functions in the
1.1 code that might issue blatant printf's.

I don't have the time to look into the CD9600 standard right now in
order to see what the RR's might be for.
-- 
cheers, J"org

joerg_wunsch@uriah.heep.sax.de -- http://www.sax.de/~joerg/
Never trust an operating system you don't have sources for. ;-)



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199507161139.NAA18993>