Date: Thu, 01 Oct 2009 16:03:20 +0200 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> To: Coleman Kane <cokane@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, "Bjoern A. Zeeb" <bz@FreeBSD.org>, src-committers@freebsd.org Subject: Re: svn commit: r197654 - head/sys/dev/if_ndis Message-ID: <86ab0bnrdj.fsf@ds4.des.no> In-Reply-To: <1254401817.4255.14.camel@localhost> (Coleman Kane's message of "Thu, 01 Oct 2009 08:56:57 -0400") References: <200910010243.n912hpSM034846@svn.freebsd.org> <86eipno12p.fsf@ds4.des.no> <1254401817.4255.14.camel@localhost>
next in thread | previous in thread | raw e-mail | index | archive | help
Coleman Kane <cokane@FreeBSD.org> writes: > Thanks, fix committed... I know style(9) says I should have not bothered > with the commit, but the assume-that-zero-is-false logic seemed > egregious enough at the time to warrant correcting it. Depends. Is ndis_80211 purely a boolean value? If yes, it should probably be a bit field; if no, style(9) clearly says that you should use an explicit comparison. (a quick perusal of the source says it isn't, so an explicit comparison is required) > I just corrected it improperly in my haste. Enjoy being able to > buildkernel again. I'll be sitting in the corner. Don't worry, you'll be in good company there :) DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86ab0bnrdj.fsf>