Date: Wed, 07 Feb 2001 16:44:59 -0800 (PST) From: John Baldwin <jhb@FreeBSD.org> To: Alfred Perlstein <bright@wintelcom.net> Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/kern uipc_mbuf.c Message-ID: <XFMail.010207164459.jhb@FreeBSD.org> In-Reply-To: <20010207163251.Z26076@fw.wintelcom.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 08-Feb-01 Alfred Perlstein wrote: > * John Baldwin <jhb@FreeBSD.org> [010207 16:28] wrote: >> jhb 2001/02/07 16:27:41 PST >> >> Modified files: >> sys/kern uipc_mbuf.c >> Log: >> Don't bother with acquiring/releasing Giant around kmem_malloc() and >> kmem_free() for now. Kmem_malloc() and kmem_free() now have appropriate >> assertions in place, and these checks aren't feasible until more of the >> networking code is locked down. Also, the extra assertions here should >> already be caught by the WITNESS code as lock order violations should >> mutex operations on Giant be reintroduced here later. > > I think this is wrong. If the drivers unwound Giant on entry before > aquiring the driver lock they would be mpsafe. Unless the vm system > is made safe making the network stack safe will have nothing to do > with this. If the drivers are MP safe and use their own locks, then yes, you can probably push Giant down this far. We aren't at that point yet, so let's wait until we get there. And if we do, probably what will be done instead is to grab Giant in the two functions in question. -- John Baldwin <jhb@FreeBSD.org> -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.Baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.010207164459.jhb>