Date: Tue, 04 Dec 2001 13:38:56 -0800 From: Andy Sparrow <spadger@best.com> To: Guido van Rooij <guido@gvr.org> Cc: Nathan Parrish <ndparrish@yahoo.com>, freebsd-mobile@FreeBSD.ORG Subject: Re: meastro3 and suspend/resume Message-ID: <20011204213856.E48A03E25@CRWdog.demon.co.uk> In-Reply-To: Your message of "Tue, 04 Dec 2001 20:31:20 %2B0100." <20011204203120.A70375@gvr.gvr.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--==_Exmh_-1182173728P
Content-Type: text/plain; charset=us-ascii
Guido. You rock. Indeed it does. Thank you.
Sound now works perfectly post-resume, with the following message:
pcm0: ac97 codec failed to reset extended mode (0, got 80)
which appears to be fairly benign (e.g. everything seems to work).
Using the mixer still seems to prevent the driver from unloading, but this is
not a problem there's now no need to unload/reload the driver all the time (or
worse, reboot) to make it work :)
Did you file a PR? Can we get this committed?
Thanks again!
Cheers,
AS
> The attached patch wil fix the suspend/resume problems.
>
> -Guido
>
> --- maestro3.c.orig Tue Dec 4 19:50:56 2001
> +++ maestro3.c Tue Dec 4 20:25:21 2001
> @@ -1304,6 +1308,8 @@
>
> reset_state = m3_assp_halt(sc);
>
> + m3_codec_reset(sc);
> +
> /* Restore the ASSP state */
> for (i = REV_B_CODE_MEMORY_BEGIN; i <= REV_B_CODE_MEMORY_END; i++)
> m3_wr_assp_code(sc, i, sc->savemem[index++]);
> @@ -1319,6 +1325,11 @@
> m3_enable_ints(sc);
>
> m3_amp_enable(sc);
> +
> + if (mixer_reinit(dev) == -1) {
> + device_printf(dev, "unable to reinitialize the mixer\n");
> + return ENXIO;
> + }
>
> /* Turn the channels back on */
> for (i=0 ; i<sc->pch_cnt ; i++) {
>
--==_Exmh_-1182173728P
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (FreeBSD)
Comment: Exmh version 2.5 07/13/2001
iD8DBQE8DUJwPHh895bDXeQRAnLdAKC0rDbSrbJ79HXRCBXFs+8WRDCD5QCgsk7A
FOJTaJnAy3eD91O5qaFOT4A=
=7Mfv
-----END PGP SIGNATURE-----
--==_Exmh_-1182173728P--
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-mobile" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20011204213856.E48A03E25>