Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 29 Jun 1996 13:52:00 +0200 (MET DST)
From:      Thomas Graichen <graichen@axp5.physik.fu-berlin.de>
To:        hackers@FreeBSD.org
Subject:   committer needed
Message-ID:  <199606291152.NAA19982@titania.physik.fu-berlin.de>

next in thread | raw e-mail | index | archive | help
hello

can someone please commit these changes to the stable tree (i currently don't
have the time and the connection to freefall to do it by myself) - you may
also commit them to -current - but i think sujal patel is working an porting a
newer version of uss/lite to FreeBSD - so i think it does'nt make much sense -
but why not

this small patch adds support for microsoft (or windows) sound system based
cards (like for instance the mad16 and mozart chips) - seems that i'm the only
one using such a card - because without these (very small) patches you'll
never get them working:

first patch - it is rquired to get the audio devices etc. if MSS != 0:

--- sys/i386/isa/sound/local.h~	Thu Sep 14 10:34:15 1995
+++ sys/i386/isa/sound/local.h	Wed Feb 14 09:11:05 1996
@@ -94,7 +94,7 @@
 
 /* nothing but a sequencer (Adlib/OPL) ? */
 #if NGUS == 0 && NSB == 0 && NSBMIDI == 0 && NPAS == 0 && NMPU == 0 && \
-    NUART == 0
+    NUART == 0 && NMSS == 0
 #ifndef EXCLUDE_MIDI
 #define EXCLUDE_MIDI
 #endif
@@ -104,7 +104,8 @@
 #endif
 
 /* nothing but a Midi (MPU/UART) ? */
-#if NGUS == 0 && NSB == 0 && NSBMIDI == 0 && NPAS == 0 && NOPL == 0
+#if NGUS == 0 && NSB == 0 && NSBMIDI == 0 && NPAS == 0 && NOPL == 0 && \
+    NMSS == 0
 /* MPU depends on sequencer timer */
 #if NMPU == 0 && !defined(EXCLUDE_SEQUENCER)
 #define EXCLUDE_SEQUENCER

second patch - this increses the auto-calibration timeout a bit - else some
cards (for instance my mad16 based shuttle sound system 48) will get a timeout
- also i don't know what the newline \n in the printf is for:

--- sys/i386/isa/sound/ad1848.c~	Thu Sep 14 10:36:43 1995
+++ sys/i386/isa/sound/ad1848.c	Mon Feb 12 17:35:20 1996
@@ -168,7 +168,7 @@
   if (!(ad_read (devc, 11) & 0x20))
     return;
 
-  timeout = 10000;
+  timeout = 20000;
   while (timeout > 0 && ad_read (devc, 11) & 0x20)
     timeout--;
   if (ad_read (devc, 11) & 0x20)
@@ -1192,7 +1192,7 @@
 	     "Generic audio codec (%s)", devc->chip_name);
 
 #if defined(__FreeBSD__)
-  printk ("\ngus0: <%s>", ad1848_pcm_operations[nr_ad1848_devs].name);
+  printk ("gus0: <%s>", ad1848_pcm_operations[nr_ad1848_devs].name);
 #else
   printk (" <%s>", ad1848_pcm_operations[nr_ad1848_devs].name);
 #endif


these two patches are working very fine for me half a year now and are that
harmlss that there are no problems including them into the stable tree -
without them the mss0 driver will definitely not work

enough told - can now please someone commit them

thanks in advance

t
 
-- 
  thomas graichen    graichen@mail.physik.fu-berlin.de    graichen@FreeBSD.org

  perfection is reached, not when there is no longer anything to add, but when
      there is no longer anything to take away    antoine de saint-exupery



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199606291152.NAA19982>