Date: Sun, 6 Dec 2009 20:47:04 +0800 From: Adrian Chadd <adrian@freebsd.org> To: Gabor Kovesdan <gabor@freebsd.org> Cc: cvs-ports@freebsd.org, cvs-all@freebsd.org, ports-committers@freebsd.org Subject: Re: cvs commit: ports/www/lusca-head/files patch-ab patch-ac Message-ID: <d763ac660912060447r43fa025dm203f0a71f849556@mail.gmail.com> In-Reply-To: <4B1B84DC.3040104@FreeBSD.org> References: <200912060958.nB69wwlm088487@repoman.freebsd.org> <4B1B84DC.3040104@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
I'm sorry for the drive-by commits like this - I had tested the port locally and deployed it in production; I didn't realise there were so many issues until after the commit. I plan on bumping the port revision once I've established that all of the post-install issues are fixed. I think they are now. I apologies for the noise, Adrian 2009/12/6 Gabor Kovesdan <gabor@freebsd.org>: > Adrian Chadd escribi=F3: >> >> adrian =A0 =A0 =A02009-12-06 09:58:58 UTC >> >> =A0FreeBSD ports repository (src committer) >> >> =A0Added files: >> =A0 =A0www/lusca-head/files patch-ab patch-ac =A0Log: >> =A0* Don't install the 'templates' error page directory. It isn't requir= ed. >> =A0* Default to "English" instead of "templates" in the configure script > > And what about the PORTREVISION bump, which is mandatory after changing t= he > install process? You know that, don't you? It would be better if you aske= d a > ports committer to help you and especially to *approve* your changes. You= r > recent commits are far from any of our conventions. I don't even dare to = ask > if you tested this on a ports tinderbox. With your src commit bit you are > able to commit to the ports tree but it doesn't mean that you can do > whatever you want. It isn't quite usual that doc/ports committers ignore > rules and commit something wrong to src without approval but it is much m= ore > common that src committers commit awkward doc and *especially* ports > changes. I would like to call the community attention (not just yours) th= at > the highest importance of the src tree doesn't mean that src committers c= an > do whatever they want in the doc and ports trees. We have our own > conventions and rules here, please respect them and ask approval from a > ports committer if you are unsure. There are a lot of helpful people, who > are glad to help and review patches. I also do that when I have time. > > -- > Gabor Kovesdan > FreeBSD Volunteer > > EMAIL: gabor@FreeBSD.org .:|:. gabor@kovesdan.org > WEB: =A0 http://people.FreeBSD.org/~gabor .:|:. http://kovesdan.org > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?d763ac660912060447r43fa025dm203f0a71f849556>