Date: Mon, 20 May 2013 17:47:58 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Jason Helfman <jgh@FreeBSD.org> Cc: Dirk Meyer <dinoex@freebsd.org>, "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, "ports-committers@freebsd.org" <ports-committers@freebsd.org> Subject: Re: svn commit: r318576 - head/mail/sendmail-sasl Message-ID: <20130520154757.GA96836@ithaqua.etoilebsd.net> In-Reply-To: <CAMuy=%2BhxQ3RX6qFZcBHK9mn4%2B92SPq2LMnzSOHdg46i4YTAJaQ@mail.gmail.com> References: <201305200715.r4K7FYmS057791@svn.freebsd.org> <CAMuy=%2BhxQ3RX6qFZcBHK9mn4%2B92SPq2LMnzSOHdg46i4YTAJaQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--LZvS9be/3tNcYl/X Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 20, 2013 at 12:25:49AM -0700, Jason Helfman wrote: > On Mon, May 20, 2013 at 12:15 AM, Dirk Meyer <dinoex@freebsd.org> wrote: >=20 > > Author: dinoex > > Date: Mon May 20 07:15:33 2013 > > New Revision: 318576 > > URL: http://svnweb.freebsd.org/changeset/ports/318576 > > > > Log: > > - fix option name > > PR: 178776 http://www.FreeBSD.org/cgi/query-pr.cgi?pr=3D17= 8776 > > Submitted by: Lawrence Chen > > > > - fix option SASLAUTHD > > > > Modified: > > head/mail/sendmail-sasl/Makefile > > > > Modified: head/mail/sendmail-sasl/Makefile > > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/mail/sendmail-sasl/Makefile Mon May 20 06:20:28 2013 > > (r318575) > > +++ head/mail/sendmail-sasl/Makefile Mon May 20 07:15:33 2013 > > (r318576) > > @@ -5,7 +5,8 @@ CATEGORIES=3D mail ipv6 > > MAINTAINER=3D dinoex@FreeBSD.org > > > > WITH_TLS=3D yes > > -WITH_SASL2=3D yes > > +WITH_SASL=3D yes > > +WITH_SASLAUTHD=3D yes > > SENDMAIL_PORT?=3D sendmail > > MASTERDIR?=3D ${.CURDIR}/../${SENDMAIL_PORT} > > > > > > > Since mail/sendmail was converted to optionsNG, shouldn't these options be > defined similarly with the new framework? Yes it should >=20 > OPTIONS_SET=3D TLS SASL2 SASL SASLAUTHD No not that way OPTIONS_SET and OPTIONS_UNSET should never ever be used in a ports Makefile OPTIONS_SLAVE has been written for that It does 2 things:=20 1- it makes sure the options are activated in the slave 2- it removes the specified options for the options the user can select. >=20 > -jgh >=20 > -- > Jason Helfman | FreeBSD Committer > jgh@FreeBSD.org | http://people.freebsd.org/~jgh | The Power to Serve --LZvS9be/3tNcYl/X Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlGaRa0ACgkQ8kTtMUmk6EyqIQCfWTlMXq6dMldtSSaQZqZhNT2y UE4AoLrJlJVaHS1N0W6qlAwRPVrnfvVg =FJ+c -----END PGP SIGNATURE----- --LZvS9be/3tNcYl/X--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130520154757.GA96836>