Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 14 Jun 2007 17:01:26 +1000 (EST)
From:      Bruce Evans <brde@optusnet.com.au>
To:        Xin LI <delphij@FreeBSD.org>
Cc:        cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sbin/mknod mknod.c
Message-ID:  <20070614170027.U31675@besplex.bde.org>
In-Reply-To: <200706140316.l5E3GIMS013585@repoman.freebsd.org>
References:  <200706140316.l5E3GIMS013585@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 14 Jun 2007, Xin LI wrote:

> delphij     2007-06-14 03:16:16 UTC
>
>  FreeBSD src repository
>
>  Modified files:
>    sbin/mknod           mknod.c
>  Log:
>  In the previous changeset a cast of myminor to u_int were
>  removed, which will cause problems on architectures where
>  longs are longer than ints, for instance,
>          "mknod foo c 0 0xffff00ff"
>  would fail in such cases.
>
>  Use a proper cast instead.
>
>  Prompted by:    bde

Thanks.

Er, it still has a wrong cast for the major number.

Bruce



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070614170027.U31675>