Date: Tue, 22 Jun 2004 13:38:59 +0200 From: Andre Oppermann <andre@freebsd.org> To: Maxim Konovalov <maxim@macomnet.ru> Cc: freebsd-current@freebsd.org Subject: Re: New preview patch for ipfw to pfil_hooks conversion Message-ID: <40D81A53.FD490D89@freebsd.org> References: <40D754D5.1070805@freebsd.org> <20040622115532.W5744@mp2.macomnet.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Maxim Konovalov wrote: > > Hi Andre, > > On Mon, 21 Jun 2004, 23:36+0200, Andre Oppermann wrote: > > > Here is the next preview patch for the ipfw to pfil_hooks conversion: > > > > http://www.nrg4u.com/freebsd/ipfw-pfilhooks-and-more-20040621.diff > > > > This patch significantly cleans up ip_input.c and ip_output.c. > > Is it possible to split that ~100KB patch in a logic chunks? One for > phil_hook, one for ip_pcbopt, one for ip_reass etc. Much easier to > review and commit them later. Of course it will be split up. I haven't done this because this is only a preview patch of work in progress. > > Consider this a FYI. It is very much a WIP at the moment. I want > > to get this into the tree in before 5.3 code freeze. > > In fact, our real world tests shown the current -CURRENT comparing to > RELENG_5_2 is in a very bad shape. Is it really worth to commit that > mostly cleanup code before say 6-CURRENT with a chance to > destabilizate -CURRENT a bit more? This will not destabilize -CURRENT anymore. Any errors in the code are seen immediatly. -- Andre
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?40D81A53.FD490D89>