Date: Tue, 1 Jul 2008 17:46:32 -0400 From: John Baldwin <jhb@freebsd.org> To: src-committers@freebsd.org Cc: cvs-src@freebsd.org, gibbs@freebsd.org, mjacob@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/mpt mpt_pci.c Message-ID: <200807011746.33319.jhb@freebsd.org> In-Reply-To: <200807011944.m61JinOJ070044@repoman.freebsd.org> References: <200807011944.m61JinOJ070044@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday 01 July 2008 03:44:38 pm John Baldwin wrote: > jhb 2008-07-01 19:44:38 UTC > > FreeBSD src repository > > Modified files: > sys/dev/mpt mpt_pci.c > Log: > SVN rev 180152 on 2008-07-01 19:44:38Z by jhb > > During shutdown, deregister the shutdown hook from the correct event > handler. > > MFC after: 2 weeks Even having an eventhandler here is dubious as the shutdown routine is already called by new-bus. At one point there was a comment suggesting that new-bus called it too late? If that is still the case, then we should probably move it to shutdown_final() and remove the 'device_shutdown' hook so new-bus doesn't call it. However, if it is fine the way it is, we should remove the explicit eventhandler so it only gets invoked once. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200807011746.33319.jhb>