Date: Mon, 18 Apr 2016 20:57:52 +0200 From: Michael Tuexen <tuexen@freebsd.org> To: Ian Lepore <ian@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r298199 - head/sys/netinet Message-ID: <3BCA34A1-0DC4-4DDF-B668-A0DAE8722011@freebsd.org> In-Reply-To: <1461001718.52955.50.camel@freebsd.org> References: <201604180929.u3I9TEA3095105@repo.freebsd.org> <1460992202.52955.49.camel@freebsd.org> <B6213F78-613D-4B03-9414-65E43782A18A@freebsd.org> <1461001718.52955.50.camel@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 18 Apr 2016, at 19:48, Ian Lepore <ian@FreeBSD.org> wrote: > > On Mon, 2016-04-18 at 18:58 +0200, Michael Tuexen wrote: >>> On 18 Apr 2016, at 17:10, Ian Lepore <ian@FreeBSD.org> wrote: >>> >>> On Mon, 2016-04-18 at 09:29 +0000, Michael Tuexen wrote: >>>> Author: tuexen >>>> Date: Mon Apr 18 09:29:14 2016 >>>> New Revision: 298199 >>>> URL: https://svnweb.freebsd.org/changeset/base/298199 >>>> >>>> Log: >>>> Put panic() calls under INVARIANTS. >>>> >>> >>> A panic that's only active when INVARIANTS is defined is usually >>> spelled KASSERT. >> OK. The change happens because when using the code in the userland >> SCTP stack, we don't provide a panic() replacement unless we >> compile the INVARIANTS defined. Therefore I catch this when compiling >> the userland stack... >> >> Best regards >> Michael >>> > > Ahh, no KASSERT in userland, thanks. I probably could have figured > that out for myself if I had put a bit of effort into looking. Well, we also have KASSERT in the userland code. All panic() calls in the SCTP code are under INVARIANTS and only the last integrated changes broke with the rule. I detected this when getting these changes into the userland code and therefore I fixed it. I'll try to convert them to KASSERTs sometime in the future. But this has not high priority right now... Thanks for making me aware of it. Best regards Michael > > -- Ian >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3BCA34A1-0DC4-4DDF-B668-A0DAE8722011>