Date: Fri, 20 Sep 2013 18:43:09 -0600 From: "Justin T. Gibbs" <gibbs@freebsd.org> To: Steven Hartland <killing@multiplay.co.uk> Cc: freebsd-current@freebsd.org, Borja Marcos <borjam@sarenet.es>, Dmitriy Makarov <supportme@ukr.net> Subject: Re: ZFS secondarycache on SSD problem on r255173 Message-ID: <C7CD8C09-9089-4850-BD12-ACF459C22405@freebsd.org> In-Reply-To: <4AA28730F331444AB13108ABF0CD68B7@multiplay.co.uk> References: <1379069539.824504225.3b9xwugp@fmst-6.ukr.net><EAD621124C1549208BD93D20657E1BD0@multiplay.co.uk><74C1D072-77BB-4D6C-B78F-C8D2731FA0CF@sarenet.es><DEF92E3685F3411D9B605ACFBEA16D94@multiplay.co.uk><1379333192.127359970.ma5jnbc5@fmst-6.ukr.net> <1379334340.567465877.0b1lli6r@fmst-6.ukr.net> <8365CE736DC749DF95D0030A725211F6@multiplay.co.uk> <02549AD9-C456-4E17-927C-B4BCC97F8CC8@freebsd.org> <4AA28730F331444AB13108ABF0CD68B7@multiplay.co.uk>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sep 17, 2013, at 4:53 PM, Steven Hartland <killing@multiplay.co.uk> = wrote: > ----- Original Message ----- From: "Justin T. Gibbs" = <gibbs@freebsd.org> >=20 >=20 >> Sorry for being slow to chime in on this thread. I live in Boulder, = CO and we've had a bit of rain. :-) >=20 > Hope all is well your side, everyone safe and sound if may be little = wetter than usual. I have been very fortunate. >> As Steven pointed out, the warning is benign, but does show that the = code I committed to >> -current is not optimizing the allocation size for L2ARC devices. = The fix for this is to find >> the best place during pool creation/load/import to call = vdev_ashift_optimize() on L2ARC >> devices. I will look into this tomorrow, but feel free to suggest a = good spot if you look at it >> before I can. >=20 > The attached patch fixes this for me, not sure if its ideal place for = it and consideration may be > needed in combination with persistent l2arc. Persistent l2arc will require storing and checking the ashift recorded = in the label so bugs and or quirk table changes don't confuse the system. But for now, with no = persistent l2arc support in the tree, I think your placement is fine. I've submitted a request = to RE so I can put your fix into head. -- Justin=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?C7CD8C09-9089-4850-BD12-ACF459C22405>