Date: Tue, 22 Jun 2004 13:45:40 +0200 From: Andre Oppermann <andre@freebsd.org> To: Maxim Konovalov <maxim@macomnet.ru> Cc: freebsd-net@freebsd.org Subject: Re: New preview patch for ipfw to pfil_hooks conversion Message-ID: <40D81BE4.B82F01A3@freebsd.org> References: <40D754D5.1070805@freebsd.org> <20040622115532.W5744@mp2.macomnet.net> <20040622133000.T6489@mp2.macomnet.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Maxim Konovalov wrote: > > On Tue, 22 Jun 2004, 02:06-0700, Luigi Rizzo wrote: > > > On Tue, Jun 22, 2004 at 12:15:21PM +0400, Maxim Konovalov wrote: > > ... > > > > Consider this a FYI. It is very much a WIP at the moment. I want > > > > to get this into the tree in before 5.3 code freeze. > > > > > > In fact, our real world tests shown the current -CURRENT comparing to > > > RELENG_5_2 is in a very bad shape. Is it really worth to commit that > > > mostly cleanup code before say 6-CURRENT with a chance to > > > > of course it is! i also do not follow the reasoning -- given that it is > > cleaning up code, it is only welcome at any stage except perhaps > > in code freeze. > > My concern is bugs. Especially in cleanup code, especially in > ip_pcbopt and ip_reass. I do not modify ip_pcbopt in any way. All the IP Options stuff is simply a 1:1 code move to get them all in one single place. For ip_reass() I've taken a very conservative approach and just moved the external code into the function itself. In terms of coding style it looks a bit ugly but is a pure 1:1 adaption of the existing code. Thus I'm sure that I haven't changed the behaviour of the ip reassembly code in any way (except one). I agree that a rewrite of ip_reass() is a very delicate thing because of possible bugs, but that is not what I have done. -- Andre
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?40D81BE4.B82F01A3>