Date: Mon, 12 Jan 2009 17:20:05 GMT From: dfilter@FreeBSD.ORG (dfilter service) To: freebsd-bugs@FreeBSD.org Subject: Re: bin/95979: commit references a PR Message-ID: <200901121720.n0CHK55Z075369@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/95979; it has been noted by GNATS. From: dfilter@FreeBSD.ORG (dfilter service) To: bug-followup@FreeBSD.org Cc: Subject: Re: bin/95979: commit references a PR Date: Mon, 12 Jan 2009 17:19:08 +0000 (UTC) Author: obrien Date: Mon Jan 12 17:18:58 2009 New Revision: 187105 URL: http://svn.freebsd.org/changeset/base/187105 Log: Fix issue where ata_atapicmd() can never really return EBUSY which is expected in acd_fixate(). This should fix various problems folks are having with 'burncd' reporting "burncd: ioctl(CDRIOCFIXATE): Input/output error" during the fixate phase when "fixate" is issued together with the "data" command. PR: 95979 Submitted by: Jaakko Heinonen <jh@saunalahti.fi> Modified: head/sys/dev/ata/ata-queue.c Modified: head/sys/dev/ata/ata-queue.c ============================================================================== --- head/sys/dev/ata/ata-queue.c Mon Jan 12 17:15:09 2009 (r187104) +++ head/sys/dev/ata/ata-queue.c Mon Jan 12 17:18:58 2009 (r187105) @@ -434,7 +434,8 @@ ata_completed(void *context, int dummy) printf("\n"); } - if ((request->u.atapi.sense.key & ATA_SENSE_KEY_MASK ? + if (!request->result && + (request->u.atapi.sense.key & ATA_SENSE_KEY_MASK ? request->u.atapi.sense.key & ATA_SENSE_KEY_MASK : request->error)) request->result = EIO; _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200901121720.n0CHK55Z075369>