Date: Tue, 13 Mar 2001 12:44:11 -0800 From: Jordan Hubbard <jkh@osd.bsdi.com> To: brian@Awfulhak.org Cc: jkh@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/sysinstall config.c Message-ID: <20010313124411W.jkh@osd.bsdi.com> In-Reply-To: <200103130857.f2D8vOS30648@hak.lan.Awfulhak.org> References: <jkh@FreeBSD.org> <200103130857.f2D8vOS30648@hak.lan.Awfulhak.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> At risk of sounding foolish because I didn't look at the diffs.... > > If you're sorting the file, are you potentially re-ordering duplicate > variable assignments, making the final answer different ? And if so, > do you really care ? This only occurs when the file is first created, not later when the possibility of (non-identical) duplicate assignments arises. If that were to happen, I most certainly would care since "YES" sorts later than "NO" and that could potentially be very bad! :-) That's why I only do it once. After that, the file is free to get as silly-looking as it likes and it probably will. The real solution to this problem is to write an rc.conf parser which sucks in all the variables, does the override checking and then spits them back out again in proper shape. There's already an rc.conf parser in sysinstall so it wouldn't actually be that hard, but this seemed like a less risky fix for now. I'll probably go commit something to -current which does it right after 4.3 comes out. - Jordan To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010313124411W.jkh>