Date: Sun, 28 Sep 2003 22:04:42 -0700 From: Brooks Davis <brooks@one-eyed-alien.net> To: Poul-Henning Kamp <phk@phk.freebsd.dk> Cc: current@freebsd.org Subject: Re: TEST PLEASE: if_tun patch Message-ID: <20030929050442.GA20995@Odin.AC.HMC.Edu> In-Reply-To: <92028.1064699839@critter.freebsd.dk> References: <92028.1064699839@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
--YZ5djTAD1cGYuMQK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Sep 27, 2003 at 11:57:19PM +0200, Poul-Henning Kamp wrote: >=20 > Please test this patch: >=20 > http://phk.freebsd.dk/patch/if_tun.patch >=20 > There is a slight change in semantics in that the interface will disappear > entirely when the /dev/tun%d device is closed. >=20 > If no objections this will be committed in some days. > | Properly dismantle and remove the interface and destroy the dev_t=20 > | at last close of the device. I'm not convinced this is the right direction to move in. The problem is that users are beginning to expect that pseudo-interfaces be created with network interface cloning, but tun, tap, and vmnet aren't. I'm concerned that this destroy on last close semantic will make it harder to implement that. I guess if we moved to a model where we allowed both methods to work, we could somehow add an extra reference when we cloned interfaces via "ifconfig <if> create", but I don't know the devfs side well enough to know if that's possible. This doesn't constitute an objection since I've had over a year to fix these drivers, but I'd appreciate it if you would give it some thought. -- Brooks P.S. Since you're moving it anyway, we make the assumption in the network code that the ifnet struct is the first member of the softc so you might want to fix tun while you're there. See the comment around if_var.h:111. --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --YZ5djTAD1cGYuMQK Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQE/d71pXY6L6fI4GtQRAvmcAJsF0CzrHrC1Z/fYAHX5ew/K2BiPwwCgr4xL 10UJaIFY1UFVmz50klFZnCA= =PnEq -----END PGP SIGNATURE----- --YZ5djTAD1cGYuMQK--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030929050442.GA20995>