Date: Wed, 7 Dec 2005 23:20:08 GMT From: Guy Harris <guy@alum.mit.edu> To: freebsd-bugs@FreeBSD.org Subject: Re: kern/89752: [bpf] [patch] bpf_validate() needs to do more checks Message-ID: <200512072320.jB7NK8r5086832@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/89752; it has been noted by GNATS. From: Guy Harris <guy@alum.mit.edu> To: Jung-uk Kim <jkim@FreeBSD.org> Cc: bug-followup@FreeBSD.org Subject: Re: kern/89752: [bpf] [patch] bpf_validate() needs to do more checks Date: Wed, 7 Dec 2005 15:11:03 -0800 On Dec 7, 2005, at 2:32 PM, Jung-uk Kim wrote: > It looks good but `bpf_maxbufsize' may be unavailable to other > consumers such as ng_bpf(4) and it doesn't make sense to them. Then that check can probably be removed - OpenBSD's consumers might all use bpf_maxbufsize, so it was OK for them, and it's just an optimization anyway (as the comment says, a "More strict check with actual packet length is done runtime"). (BTW, this was from OpenBSD; if you check it in, say it's from Otto Moerbeek's changes to OpenBSD, do *NOT* give me direct credit for it!)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200512072320.jB7NK8r5086832>