Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 7 Oct 2002 19:57:37 -0700 (PDT)
From:      Jamie Aczel <temperanza@softhome.net>
To:        freebsd-gnats-submit@FreeBSD.org
Subject:   ports/43809: patch for audio/gdcd
Message-ID:  <200210080257.g982vbN2046539@www.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         43809
>Category:       ports
>Synopsis:       patch for audio/gdcd
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Oct 07 20:00:13 PDT 2002
>Closed-Date:
>Last-Modified:
>Originator:     Jamie Aczel
>Release:        4.7-RC
>Organization:
n/a
>Environment:
>Description:
This is a patch I hacked out to correct one build problem with gdcd, caused by a variable namechange in new versions of libcdaudio. The port builds now but segfaults in strncpy() - please get a better programer to figure out why.

I hope the shar submits properly- haven't managed to get sendmail configured so the local send-pr won't work on my machine. Sorry ._.
>How-To-Repeat:
Error I patched: Just build the port as it is.

New error:

This GDB was configured as "i386-unknown-freebsd"...
(no debugging symbols found)...
Core was generated by `gdcd'.
Program terminated with signal 11, Segmentation fault.
#0  0x285fdac8 in strncpy () from /usr/lib/libc_r.so.4
>Fix:
# This is a shell archive.  Save it in a file, remove anything before
# this line, and then unpack it by entering "sh file".  Note, it may
# create directories; files and directories will be owned by you and
# have default permissions.
#
# This archive contains:
#
#	patch-ai
#
echo x - patch-ai
sed 's/^X//' >patch-ai << 'END-of-patch-ai'
X--- source/coverart.c.orig	Mon Oct  7 18:31:11 2002
X+++ source/coverart.c	Mon Oct  7 18:30:37 2002
X@@ -96,7 +96,7 @@
X 	 return NULL;
X       }
X       
X+      write(fd, art.art_image, art.art_length);
X-      write(fd, art.art_data, art.art_length);
X       close(fd);
X       
X       thread_invoke_operation(display_sock, "COVR", filename, strlen(filename));
X@@ -167,7 +167,7 @@
X 	 return NULL;
X       }
X       
X+      write(fd, art.art_image, art.art_length);
X-      write(fd, art.art_data, art.art_length);
X       close(fd);
X    } else
X       snprintf(filename, 108, "L%s.png", cddb_genre(data.data_genre));
END-of-patch-ai
exit
>Release-Note:
>Audit-Trail:
>Unformatted:

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200210080257.g982vbN2046539>