Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 30 Aug 2005 17:18:05 +0100 (BST)
From:      Mark Murray <markm@FreeBSD.org>
To:        FreeBSD-gnats-submit@FreeBSD.org
Subject:   ports/85490: [PATCH] If WANT_LINT is set, port building can break
Message-ID:  <200508301618.j7UGI5Kp052947@grunt.grondar.org>
Resent-Message-ID: <200508301630.j7UGUGUk059498@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         85490
>Category:       ports
>Synopsis:       [PATCH] If WANT_LINT is set, port building can break
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Aug 30 16:30:15 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator:     Mark Murray
>Release:        FreeBSD 6.0-BETA3 i386
>Organization:
GTA
>Environment:
System: FreeBSD grunt.grondar.org 6.0-BETA3 FreeBSD 6.0-BETA3 #1: Mon Aug 29 20:50:36 BST 2005 root@grunt.grondar.org:/usr/src/sys/i386/compile/G_X86_32 i386


	All ports that build libraries using the BSD bsd.lib.mk macro sets.
>Description:
	If WANT_LINT is set in /etc/make.conf, then ports that use
	the /usr/share/mk/bsd.lib.mk macros to make libraries will
	also try to lint the code, and will fail when no place is
	found to install the lint library. Linting ports is of no
	use to the FreeBSD Project, as it only generates output that
	would be of use to the code author. Linting needs to be turned
	off summarily for all port work, and the NO_LINT macro is
	intended for this purpose (also for src/contrib code).
>How-To-Repeat:
	Build a port which uses the bsd.lib.mk, while WANT_LINT is
	turned on in /etc/make.conf. Example ports/graphics/png
>Fix:


Index: bsd.port.mk
===================================================================
RCS file: /home/ncvs/ports/Mk/bsd.port.mk,v
retrieving revision 1.516
diff -u -d -r1.516 bsd.port.mk
--- bsd.port.mk	28 Aug 2005 18:47:56 -0000	1.516
+++ bsd.port.mk	29 Aug 2005 09:52:35 -0000
@@ -1424,7 +1424,7 @@
 
 CONFIGURE_ENV+=	SHELL=${SH} CONFIG_SHELL=${SH} PORTOBJFORMAT=${PORTOBJFORMAT}
 SCRIPTS_ENV+=	PORTOBJFORMAT=${PORTOBJFORMAT}
-MAKE_ENV+=		SHELL=${SH} PORTOBJFORMAT=${PORTOBJFORMAT}
+MAKE_ENV+=		SHELL=${SH} PORTOBJFORMAT=${PORTOBJFORMAT} NO_LINT=YES
 PLIST_SUB+=		PORTOBJFORMAT=${PORTOBJFORMAT}
 
 .if defined(MANCOMPRESSED)

>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200508301618.j7UGI5Kp052947>