Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 8 Dec 2013 18:48:07 +0000 (UTC)
From:      Jean-Sebastien Pedron <dumbbell@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r259104 - head/sys/dev/drm2/radeon
Message-ID:  <201312081848.rB8Im7o7096182@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: dumbbell
Date: Sun Dec  8 18:48:07 2013
New Revision: 259104
URL: http://svnweb.freebsd.org/changeset/base/259104

Log:
  drm/radeon: radeon_dp_i2c_aux_ch() must return 0 on FreeBSD
  
  The code was unmodified compared to Linux and returned the amount of
  received bytes from the i2c bus. This led to non-working i2c bus and
  failure to eg. read monitor's EDID, if connected to DisplayPort.
  
  MFC after:	3 days
  Tested by:	Mikaƫl Urankar <mikael.urankar@gmail.com>

Modified:
  head/sys/dev/drm2/radeon/atombios_dp.c

Modified: head/sys/dev/drm2/radeon/atombios_dp.c
==============================================================================
--- head/sys/dev/drm2/radeon/atombios_dp.c	Sun Dec  8 17:47:37 2013	(r259103)
+++ head/sys/dev/drm2/radeon/atombios_dp.c	Sun Dec  8 18:48:07 2013	(r259104)
@@ -272,7 +272,7 @@ int radeon_dp_i2c_aux_ch(device_t dev, i
 		case AUX_I2C_REPLY_ACK:
 			if (mode == MODE_I2C_READ)
 				*read_byte = reply[0];
-			return ret;
+			return (0); /* Return ret on Linux. */
 		case AUX_I2C_REPLY_NACK:
 			DRM_DEBUG_KMS("aux_i2c nack\n");
 			return -EREMOTEIO;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201312081848.rB8Im7o7096182>