Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 9 Dec 2003 09:07:04 -0800
From:      "David O'Brien" <obrien@freebsd.org>
To:        Clement Laforet <sheepkiller@cultdeadsheep.org>
Cc:        Guido Falsi <mad@madpilot.net>
Subject:   Re: added Moxa multiserial board PCI id to puc(4)
Message-ID:  <20031209170704.GA19222@dragon.nuxi.com>
In-Reply-To: <20031209132148.3ba7c176.sheepkiller@cultdeadsheep.org>
References:  <20031209121900.GA4691@wedge.madpilot.net> <20031209132148.3ba7c176.sheepkiller@cultdeadsheep.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Dec 09, 2003 at 01:21:48PM +0000, Clement Laforet wrote:
> On Tue, 9 Dec 2003 13:19:00 +0100
> Guido Falsi <mad@madpilot.net> wrote:
> > 
> > Thank you again for the good work. Hope someone will give this a chance
> > to get in the repository :)
> 
> You will have better chance to get your patch committed is you send a PR ;-)

Nope, he'd have a better chance getting the patch committed if it
actually applied:

    foo:/sys/dev/puc> patch < /tmp/p
    Hmm...  Looks like a unified diff to me...
    The text leading up to this was:
    --------------------------
    |--- pucdata.c.orig      Tue Dec  9 13:15:34 2003
    |+++ pucdata.c   Tue Dec  9 13:14:28 2003
    --------------------------
    Patching file pucdata.c using Plan A...
    Hunk #1 failed at 1015.
    1 out of 1 hunks failed--saving rejects to pucdata.c.rej
    Hmm...  Ignoring the trailing garbage.
    done

the MUA stripped the tabs.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20031209170704.GA19222>