Date: Mon, 20 May 2013 19:49:04 +0200 From: Baptiste Daroussin <bapt@freebsd.org> To: Jason Helfman <jgh@FreeBSD.org> Cc: Dirk Meyer <dinoex@freebsd.org>, "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, "ports-committers@freebsd.org" <ports-committers@freebsd.org> Subject: Re: svn commit: r318576 - head/mail/sendmail-sasl Message-ID: <20130520174904.GB96836@ithaqua.etoilebsd.net> In-Reply-To: <CAMuy=%2Bht9aHd6=NKMQC0e=HoKg0Nm3mw9M9qtzQdNoc3kxoPgg@mail.gmail.com> References: <201305200715.r4K7FYmS057791@svn.freebsd.org> <CAMuy=%2BhxQ3RX6qFZcBHK9mn4%2B92SPq2LMnzSOHdg46i4YTAJaQ@mail.gmail.com> <20130520154757.GA96836@ithaqua.etoilebsd.net> <CAMuy=%2Bht9aHd6=NKMQC0e=HoKg0Nm3mw9M9qtzQdNoc3kxoPgg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--gatW/ieO32f1wygP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 20, 2013 at 10:35:17AM -0700, Jason Helfman wrote: > On Mon, May 20, 2013 at 8:47 AM, Baptiste Daroussin <bapt@freebsd.org>wro= te: >=20 > > > Since mail/sendmail was converted to optionsNG, shouldn't these optio= ns > > be > > > defined similarly with the new framework? > > > > Yes it should > > > > > > OPTIONS_SET=3D TLS SASL2 SASL SASLAUTHD > > > > No not that way OPTIONS_SET and OPTIONS_UNSET should never ever be used= in > > a > > ports Makefile > > > > My apologies for this advice. I forgot that this can't be noted in > Makefile. It was PORT_OPTIONS at one point that should be defined. >=20 >=20 > > OPTIONS_SLAVE has been written for that > > It does 2 things: > > 1- it makes sure the options are activated in the slave > > 2- it removes the specified options for the options the user can select. > > >=20 > Very nice. I haven't used this, yet. I do see the commit about this now, > however has it been included in the Handbook or CHANGES? Sounds like it > would be well worth an inclusion if not. >=20 > Thanks bapt! Great addition. >=20 Nope this is fresh I should document it, I'll do in a couple of days if I d= o not forget about it :) regards, Bapt --gatW/ieO32f1wygP Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlGaYhAACgkQ8kTtMUmk6Ez9rwCeM+yEGoVGo0RpG1VplN94Kurr hvYAniIpYCde9BF+K+beiZkfJgsjCTds =Zu5Z -----END PGP SIGNATURE----- --gatW/ieO32f1wygP--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130520174904.GB96836>