Date: Wed, 10 Oct 2001 22:31:05 +0100 From: AMAKAWA Shuhei <sa264@cam.ac.uk> To: FreeBSD-gnats-submit@freebsd.org Cc: tonym@biolateral.com.au Subject: ports/31208: Fix bugs in net/generic-nqs. Now it really works! Message-ID: <E15rQwT-000HY0-00@m218-3.phy.cam.ac.uk>
next in thread | raw e-mail | index | archive | help
>Number: 31208
>Category: ports
>Synopsis: Fix bugs in net/generic-nqs. Now it really works!
>Confidential: no
>Severity: non-critical
>Priority: high
>Responsible: freebsd-ports
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Wed Oct 10 14:40:01 PDT 2001
>Closed-Date:
>Last-Modified:
>Originator: AMAKAWA Shuhei
>Release: FreeBSD 4.4-STABLE i386
>Organization:
>Environment:
System: FreeBSD m218-3.phy.cam.ac.uk 4.4-STABLE FreeBSD 4.4-STABLE #1: Fri Oct 5 00:32:28 BST 2001 sa264@m218-3.phy.cam.ac.uk:/usr/obj/usr/src/sys/KERNCONF i386
>Description:
Make Generic-NQS actually work properly.
files/patch-ab is empty so should be removed.
files/patch-ah fixes the bug which prevented NQS from sending emails.
files/patch-ai fixes the bug which caused removal of jobs from a pipe queue
when all the inbound-load-balanced queues that follow it are busy.
files/nqs.sh really kills the nqsdaemon.
>How-To-Repeat:
Try the workstation cluster example configuration given in the
document provided.
>Fix:
Removed file:
files/patch-ab
Added files:
files/patch-ah
files/patch-ai
diff -uNr /usr/ports/net/generic-nqs/Makefile generic-nqs/Makefile
--- /usr/ports/net/generic-nqs/Makefile Wed Oct 10 21:56:06 2001
+++ generic-nqs/Makefile Wed Oct 10 22:18:31 2001
@@ -9,7 +9,7 @@
PORTNAME= Generic-NQS
PORTVERSION= 3.50.9
-PORTREVISION= 1
+PORTREVISION= 2
CATEGORIES= net
MASTER_SITES= ${MASTER_SITE_LOCAL}
MASTER_SITE_SUBDIR= fenner
diff -uNr /usr/ports/net/generic-nqs/files/nqs.sh generic-nqs/files/nqs.sh
--- /usr/ports/net/generic-nqs/files/nqs.sh Wed Jul 5 13:36:41 2000
+++ generic-nqs/files/nqs.sh Sun Oct 7 17:48:40 2001
@@ -8,7 +8,7 @@
fi
;;
stop)
- killall nqsdaemon && echo -n ' nqs'
+ killall -KILL nqsdaemon netdaemon loaddaemon && echo -n ' nqs'
;;
*)
echo "Usage: `basename $0` {start|stop}" >&2
diff -uNr /usr/ports/net/generic-nqs/files/patch-ah generic-nqs/files/patch-ah
--- /usr/ports/net/generic-nqs/files/patch-ah Thu Jan 1 01:00:00 1970
+++ generic-nqs/files/patch-ah Sat Oct 6 10:22:14 2001
@@ -0,0 +1,19 @@
+--- Source-Tree/nqsdaemon/all-systems/nqs_mai.c.orig Sun Mar 19 13:19:21 2000
++++ Source-Tree/nqsdaemon/all-systems/nqs_mai.c Sat Oct 6 10:21:00 2001
+@@ -247,8 +247,14 @@
+ argv [0] = "mail";
+ argv [1] = maildest;
+ argv [2] = (char *) 0;
+- execve ("/bin/mail", argv, /* Execve() mail program */
+- envp);
++ {
++ struct stat stb;
++ if (stat("/bin/mail", &stb) != -1)
++ execve ("/bin/mail",/* Execve() mail program */
++ argv, envp);
++ else if (stat("/usr/bin/mail", &stb) != -1)
++ execve ("/usr/bin/mail", argv, envp);
++ }
+ _exit (1);
+ }
+ else if (pid == -1) return (-1); /* Fork failed */
diff -uNr /usr/ports/net/generic-nqs/files/patch-ai generic-nqs/files/patch-ai
--- /usr/ports/net/generic-nqs/files/patch-ai Thu Jan 1 01:00:00 1970
+++ generic-nqs/files/patch-ai Tue Oct 9 10:52:38 2001
@@ -0,0 +1,14 @@
+--- Source-Tree/pipeclient/all-systems/pipeclient.c.orig Sun Mar 19 13:19:42 2000
++++ Source-Tree/pipeclient/all-systems/pipeclient.c Tue Oct 9 10:51:53 2001
+@@ -1059,7 +1059,11 @@
+ signal(SIGPIPE, catch_sigpipe);
+
+ do {
++#if HAS_BSD_PIPE
++ interconn();
++#else
+ interset(-1);
++#endif
+ interclear ();
+ interw32i (rawreq->orig_seqno);
+ interw32u (rawreq->orig_mid);
>Release-Note:
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E15rQwT-000HY0-00>