Date: Sat, 19 Jan 2013 13:35:37 +0000 From: Chris Rees <crees@FreeBSD.org> To: Poul-Henning Kamp <phk@phk.freebsd.dk> Cc: "ports@freebsd.org" <ports@freebsd.org> Subject: Re: Ports, bsd.lib.mk and NOPROFILE Message-ID: <CADLo839_hOwbiqF_SvE-Uc9RE6guMJz2JOufjq8jE=zkOsd=ww@mail.gmail.com> In-Reply-To: <45933.1358559937@critter.freebsd.dk> References: <45933.1358559937@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
On 19 January 2013 01:45, Poul-Henning Kamp <phk@phk.freebsd.dk> wrote: > > I just tried to build a system with -CURRENT from scratch, and it fell over > in graphics/gd because NOPROFILE is now named NO_PROFILE in bsd.lib.mk > > grep(1) tells me that a number of other ports will also have this problem > > It may be appropriate with a bandaid in bsd.lib.mk, which emits a noisy > warning, until all these ports are fixed. > > A good grep strategy is to look for files containing "NOPROFILE" and > "bsd.lib.mk" but they need not be on the same line. The two examples you showed in IRC didn't contain bsd.lib.mk-- but I see no problem in simply changing all the instances of NO(PROFILE|MAN) to NO_\1. We know that a bandaid is effectively a revert of the removal; would be better to simply fix the ports. Only issue is, this doesn't catch ports that use these variables in upstream; an exp-run is required for that... I'm running a grep for those two above-- are there any more I've missed? Chris
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADLo839_hOwbiqF_SvE-Uc9RE6guMJz2JOufjq8jE=zkOsd=ww>