Date: Fri, 03 Mar 2006 21:53:07 +0000 From: "Poul-Henning Kamp" <phk@phk.freebsd.dk> To: Pawel Jakub Dawidek <pjd@FreeBSD.org> Cc: cvs-src@FreeBSD.org, Jeff Roberson <jeff@FreeBSD.org>, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/geom geom_vfs.c Message-ID: <28476.1141422787@critter.freebsd.dk> In-Reply-To: Your message of "Fri, 03 Mar 2006 22:48:19 %2B0100." <20060303214819.GB11030@garage.freebsd.pl>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <20060303214819.GB11030@garage.freebsd.pl>, Pawel Jakub Dawidek writ es: >+> g_topology_assert(); >+> @@ -147,7 +148,9 @@ g_vfs_open(struct vnode *vp, struct g_co >+> g_wither_geom(gp, ENXIO); >+> return (error); >+> } >+> + vfslocked =3D VFS_LOCK_GIANT(vp->v_mount); >+> vnode_create_vobject(vp, pp->mediasize, curthread); >+> + VFS_UNLOCK_GIANT(vfslocked); > >Acquiring Giant while holding the topology lock is a bad thing, AFAIK. >CCing phk@ to correct me if I'm wrong or explain why exactly I'm right. topology -> Giant is hopefully the correct order of not a lot of trouble should be had in geom_dev when we call make_dev(). -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?28476.1141422787>