Date: Wed, 01 Jun 2011 11:57:08 +0300 From: Andriy Gapon <avg@FreeBSD.org> To: Attilio Rao <attilio@FreeBSD.org> Cc: Matthew Fleming <mdf@FreeBSD.org>, src-committers@FreeBSD.org, Pawel Jakub Dawidek <pjd@FreeBSD.org>, svn-src-user@FreeBSD.org Subject: Re: svn commit: r222060 - in user/avg/xcpu/sys: kern sys Message-ID: <4DE5FEE4.9000806@FreeBSD.org> In-Reply-To: <BANLkTi=At3PmadVJCzyZ%2BcHkBoB13BAdDg@mail.gmail.com> References: <201105181508.p4IF8UoS096841@svn.freebsd.org> <20110518182441.GB2273@garage.freebsd.pl> <4DD4243C.4070301@FreeBSD.org> <BANLkTikAnB-3XbvDwGHgyqyJquH9BhqzOQ@mail.gmail.com> <4DDD13F9.5040800@FreeBSD.org> <4DDE7555.7090500@FreeBSD.org> <BANLkTi=m4x2H2vvn48nCv%2BT2--HfSaT2Gw@mail.gmail.com> <4DDF44E8.9030208@FreeBSD.org> <BANLkTi=At3PmadVJCzyZ%2BcHkBoB13BAdDg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
on 29/05/2011 06:08 Attilio Rao said the following: > 2011/5/27 Andriy Gapon <avg@freebsd.org>: >> on 26/05/2011 19:41 Attilio Rao said the following: >>> Yes, I think it would be better something like SYSTEM_IN_PANIC() or such. >> >> How about SCHEDULER_STOPPED() ? >> > > I think the name should be in the "panic" ballpark rather than the > "scheduler" one. Actually I am growing fond of this name as it accurately reflects state of a system and why we want to skip locks. OTOH, I can not imagine other cases besides panic where we would want to stop scheduler and skip locks, so maybe something like SCHEDULER_STOPPED_ IN/BY/FOR _PANIC ? SCHEDULER_STOPPED looks more appealing to me because of its brevity. I also want to rename stop_cpus_on_panic knob to stop_scheduler_on_panic for all the same reasons. It would also control doing critical_enter() [as we do now] vs spinlock_enter() [as I want to do], so it becomes used even in the UP case. > Anyway I don't really care too much about the name, I just think we > should have it in system.h, where also panic() lives. I agree. -- Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4DE5FEE4.9000806>