Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 19 Nov 2005 12:02:33 -1000
From:      juli mallett <jmallett@FreeBSD.org>
To:        Ed Maste <emaste@FreeBSD.org>
Cc:        cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/sys queue.h
Message-ID:  <20051119220233.GA5935@toxic.magnesium.net>
In-Reply-To: <200511181941.jAIJftnL027282@repoman.freebsd.org>
References:  <200511181941.jAIJftnL027282@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Maybe it should be KERNEL && INVARIANTS, for the sake of userland apps
using queue.h which may have their own INVARIANTS define but not their
own panic(9) implementation?

* Ed Maste <emaste@FreeBSD.org> [ Date: 2005-11-18 ]
	[ w.r.t. cvs commit: src/sys/sys queue.h ]
> emaste      2005-11-18 19:41:55 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/sys              queue.h 
>   Log:
>   Add sanity checking for QUEUE(3) lists under INVARIANTS.  Races may lead
>   to list corruption, which can be difficult to unravel in a post-mortem
>   analysis.  These checks verify that prev and next pointers are consistent
>   when inserting or removing elements, thus catching any corruption earlier.
>   
>   Also use TRASHIT to break LIST and SLIST link pointers on element removal,
>   from mlaier via -hackers.
>   
>   Reviewed by:    mlaier
>   Approved by:    rwatson (mentor)
>   
>   Revision  Changes    Path
>   1.62      +35 -2     src/sys/sys/queue.h

-- 
Go to sleep.  Go to sleep.  Go to sleep.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051119220233.GA5935>