Date: Sat, 12 Nov 2016 19:03:42 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 194109] [lor] if_lagg rmlock <-> if_addr_lock Message-ID: <bug-194109-2472-ssBLgnBFRF@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-194109-2472@https.bugs.freebsd.org/bugzilla/> References: <bug-194109-2472@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D194109 --- Comment #7 from commit-hook@freebsd.org --- A commit references this bug: Author: rstone Date: Sat Nov 12 19:03:24 UTC 2016 New revision: 308580 URL: https://svnweb.freebsd.org/changeset/base/308580 Log: Don't read if_counters with if_addr_lock held Calling into an ifnet implementation with the if_addr_lock already held can cause a LOR and potentially a deadlock, as ifnet implementations typically can take the if_addr_lock after their own locks during configuration. Refactor a sysctl handler that was violating this to read if_counter data in a temporary buffer before the if_addr_lock is taken, and then copying the data in its final location later, when the if_addr_lock is held. PR: 194109 Reported by: Jean-Sebastien Pedron MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D8498 Reviewed by: sbruno Changes: head/sys/net/rtsock.c --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-194109-2472-ssBLgnBFRF>