Date: Wed, 03 Jul 2013 18:51:50 +0900 (JST) From: Hiroki Sato <hrs@FreeBSD.org> To: uqs@FreeBSD.org Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r252408 - head/sbin/ifconfig Message-ID: <20130703.185150.1466238345990988743.hrs@allbsd.org> In-Reply-To: <20130703092307.GA2294@acme.spoerlein.net> References: <201306300737.r5U7bWkB096070@svn.freebsd.org> <20130703092307.GA2294@acme.spoerlein.net>
next in thread | previous in thread | raw e-mail | index | archive | help
----Security_Multipart(Wed_Jul__3_18_51_50_2013_293)--
Content-Type: Text/Plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
Ulrich Sp=F6rlein <uqs@FreeBSD.org> wrote
in <20130703092307.GA2294@acme.spoerlein.net>:
uq> > if ((s6 =3D socket(AF_INET6, SOCK_DGRAM, 0)) < 0) {
uq> > - if (errno !=3D EAFNOSUPPORT)
uq> > + if (errno !=3D EAFNOSUPPORT && error !=3D EPROTONOSUPPORT)
uq> > warn("socket(AF_INET6, SOCK_DGRAM)");
uq> > return;
uq> > }
uq> =
uq> This gives undefined behavior, error is uninitialized at this point=
.=
uq> =
uq> Found by: Coverity Scan, CID 1042128
=
Gr, fixed just now. Thank you for the report!
-- Hiroki
----Security_Multipart(Wed_Jul__3_18_51_50_2013_293)--
Content-Type: application/pgp-signature
Content-Transfer-Encoding: 7bit
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.13 (FreeBSD)
iEYEABECAAYFAlHT9DYACgkQTyzT2CeTzy3fnACgjvHVE7v9LSAF+Ju0D1sfamB3
t4UAoM7oXuub3FJ1FlcQ8mYahZncpeRl
=OJBL
-----END PGP SIGNATURE-----
----Security_Multipart(Wed_Jul__3_18_51_50_2013_293)----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130703.185150.1466238345990988743.hrs>