Date: Fri, 3 May 2013 16:50:12 -0400 From: John Baldwin <jhb@freebsd.org> To: Konstantin Belousov <kostikbel@gmail.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r250193 - head/sys/fs/msdosfs Message-ID: <201305031650.12397.jhb@freebsd.org> In-Reply-To: <20130503203541.GS3047@kib.kiev.ua> References: <201305022000.r42K0Bdk098965@svn.freebsd.org> <201305031155.47559.jhb@freebsd.org> <20130503203541.GS3047@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On Friday, May 03, 2013 4:35:41 pm Konstantin Belousov wrote: > On Fri, May 03, 2013 at 11:55:47AM -0400, John Baldwin wrote: > > On Thursday, May 02, 2013 4:00:11 pm Konstantin Belousov wrote: > > > Author: kib > > > Date: Thu May 2 20:00:11 2013 > > > New Revision: 250193 > > > URL: http://svnweb.freebsd.org/changeset/base/250193 > > > > > > Log: > > > The fsync(2) call should sync the vnode in such way that even after > > > system crash which happen after successfull fsync() return, the data > > > is accessible. For msdosfs, this means that FAT entries for the file > > > must be written. > > > > > > Since we do not track the FAT blocks containing entries for the > > > current file, just do a sloppy sync of the devvp vnode for the mount, > > > which buffers, among other things, contain FAT blocks. > ... > > > Does this fix kern/62762? > > > > Supposedly yes, I even possibly have seen this PR before. > At least, it is understandable why do you remember about it now. > > I definitely do not want to take the approach of precisely calculating > the list of FAT blocks which needs to be synced. No, that seems too painful. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201305031650.12397.jhb>