Date: Tue, 25 Jan 2005 12:09:33 +0100 From: "Poul-Henning Kamp" <phk@phk.freebsd.dk> To: Andrey Chernov <ache@nagual.pp.ru> Cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/kern sys_generic.c Message-ID: <81636.1106651373@critter.freebsd.dk> In-Reply-To: Your message of "Tue, 25 Jan 2005 14:06:48 %2B0300." <20050125110648.GB29791@nagual.pp.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <20050125110648.GB29791@nagual.pp.ru>, Andrey Chernov writes: >On Tue, Jan 25, 2005 at 01:58:11PM +0300, Andrey Chernov wrote: >> What's about "invalid buffer pointers" detection, directly mentioned in >> the standard (above)? Now it is broken for zero bytes read because your >> newly inserted check takes precedence. > >The next precedence violation candidate in error detection will be: > >"[EIO] >The process is a member of a background process attempting to read from >its controlling terminal, the process is ignoring or blocking the SIGTTIN >signal, or the process group is orphaned." > >I.e. look at ERRORS section list and inspect each errno returning broken >by preliminary zero bytes check. That's another check we didn't do before to the resid==0 handling before. Now, I'm going to killfile this subject until you come up with code which real-life code which breaks because of this, OK ? Bye... -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?81636.1106651373>