Date: Fri, 14 Nov 2014 21:20:57 +0300 From: Gleb Smirnoff <glebius@FreeBSD.org> To: Garrett Cooper <yaneurabeya@gmail.com> Cc: svn-src-projects@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r274517 - projects/sendfile/sys/vm Message-ID: <20141114182057.GD1031@FreeBSD.org> In-Reply-To: <F29804BE-DBDD-45D7-AC71-D1B9482C4415@gmail.com> References: <201411141801.sAEI1IWo066725@svn.freebsd.org> <F29804BE-DBDD-45D7-AC71-D1B9482C4415@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Nov 14, 2014 at 10:17:35AM -0800, Garrett Cooper wrote: G> > Log: G> > Use C99 "inline" keyword. G> > G> > Modified: G> > projects/sendfile/sys/vm/vm_pager.h G> > G> > Modified: projects/sendfile/sys/vm/vm_pager.h G> > ============================================================================== G> > --- projects/sendfile/sys/vm/vm_pager.h Fri Nov 14 18:00:00 2014 (r274516) G> > +++ projects/sendfile/sys/vm/vm_pager.h Fri Nov 14 18:01:18 2014 (r274517) G> > @@ -106,7 +106,7 @@ vm_object_t vm_pager_allocate(objtype_t, G> > void vm_pager_bufferinit(void); G> > void vm_pager_deallocate(vm_object_t); G> > static __inline int vm_pager_get_pages(vm_object_t, vm_page_t *, int, int); G> > -static __inline int vm_pager_get_pages_async(vm_object_t, vm_page_t *, int, G> > +static inline int vm_pager_get_pages_async(vm_object_t, vm_page_t *, int, G> > int, void(*)(void *, int), void *); G> > static __inline boolean_t vm_pager_has_page(vm_object_t, vm_pindex_t, int *, int *); G> > void vm_pager_init(void); G> > @@ -138,7 +138,7 @@ vm_pager_get_pages( G> > return (r); G> > } G> G> - What was wrong with using the "non-C99" constant? It was compiler keyword from XX century. G> - Why not the other cases above that, e.g. vm_pager_get_pages? Alan asks to avoid any style(9) changes to sys/vm, so that svn annotate works. However, new code should be styled properly. -- Totus tuus, Glebius.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20141114182057.GD1031>