Date: Sat, 19 Jan 2013 23:53:43 +0100 (CET) From: Juergen Lock <nox@jelal.kn-bremen.de> To: r.c.ladan@gmail.com Cc: freebsd-ports@freebsd.org Subject: Re: CFT: building multimedia/vlc with clang on 9.1+ Message-ID: <201301192253.r0JMrhsa080013@triton8.kn-bremen.de> In-Reply-To: <50FB156A.5010003@gmail.com> References: <20130119210903.GA76282@triton8.kn-bremen.de>
next in thread | previous in thread | raw e-mail | index | archive | help
In article <50FB156A.5010003@gmail.com> you write:
>On 19-01-2013 22:09, Juergen Lock wrote:
>> Hi!
>>
>> As having to depend on gcc 4.6+ on i386 is kindof a waste on 9.1+
>> where we have clang too, and clang might generate better code than
>> the old gcc 4.2.1 in base on amd64 anyway I thought what if we have
>> the vlc port default to using clang on 9.1+ when it's available?
>> So I propse the patch below for testing by anyone on 9.1 or later,
>> also on i386 where I can't test myself, please report any issues
>> or regressions you find.
>>
>I've been running vlc on 10-amd64 with clang for a while now without any
>(serious) problems.
>
>> Index: Makefile
>> ===================================================================
>> RCS file: /home/pcvs/ports/multimedia/vlc/Makefile,v
>> retrieving revision 1.312
>> diff -u -p -r1.312 Makefile
>> --- Makefile 12 Jan 2013 20:25:57 -0000 1.312
>> +++ Makefile 19 Jan 2013 20:45:39 -0000
>> @@ -679,9 +679,16 @@ IGNORE= base clang version too old, set
>> CONFIGURE_ARGS+=--enable-altivec # VLC's config script doesn't know to do this
>> .endif
>>
>> +# prefer clang on 9.1+
>> +.if (${OSVERSION} >= 901000) && exists(${DESTDIR}/usr/bin/clang)
>
>Not sure if this is the proper(TM) way to detect clang.
>> +CC= clang
>> +CXX= clang++
>> +CPP= clang-cpp
>> +.else
>> .if ${ARCH} == "i386"
>> USE_GCC?= 4.6+ # sse/3dnow detection on i386 needs newer gcc
>
>See above, if on e.g. FreeBSD 12 the /usr/bin/clang file gets removed
>this makes the port always use GCC 4.6+
>
Hmm do you think this would happen? We still had /usr/bin/gcc hardlinked
to /usr/bin/cc the entire time we used gcc...
Hmm,
Juergen
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201301192253.r0JMrhsa080013>