Date: Tue, 10 Jul 2007 09:38:29 +0200 From: Alexander Leidinger <Alexander@Leidinger.net> To: Christopher Davis <loafier@FreeBSD.org> Cc: freebsd-hackers@FreeBSD.org, Ariff@FreeBSD.org, multimedia@FreeBSD.org Subject: Re: Audio driver template Message-ID: <20070710093829.34mqbekao4wwww4s@webmail.leidinger.net> In-Reply-To: <c44ca55f0707091147n48741250h588a1fcf59d1b74b@mail.gmail.com> References: <c44ca55f0707091147n48741250h588a1fcf59d1b74b@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Quoting Christopher Davis <loafier@FreeBSD.org> (from Mon, 9 Jul 2007 =20 11:47:14 -0700): > http://people.freebsd.org/~cg/template.c > > Thought I would take a look at the audio driver template as > part of my task to modernize drivers, soc2007. I would simplify > the read and write functions to avoid using the bus tag and > handle, but I'm not sure what else to do to bring it up to date. > > How else can it be improved? Putting it into the examples directory instead of having it on the =20 people's own pages would be an improvement (the developer handbook =20 needs to be changed to point to the examples directory then). And you should clarify what kind of improvements are valid for your =20 SoC work. Somehow I doubt that adding shiny new features (like hps =20 suggested) is part of the goal for your work. I think it's more like =20 bringing existing drivers up-to-par with currently available generic =20 driver interfaces, isn't it? I also think examples for suspend/resume stuff should be added. =20 /sys/dev/sound/pci/atiixp.c has suspend and resume methods if you want =20 an example. You could also review the locking, as it changed a little bit =20 recently, I think. Apart from the atiixp driver the envy42, emu10kx and HDA drivers can =20 also serve as examples for what is the most current in the sound =20 subsystem in FreeBSD. Maybe you can gain some more hints from them (I =20 think the template is not very up-to-date compared to them). The new mixer interface is not used yet in the drivers, so we don't =20 have examples at all for them. You could ask ryanb@FreeBSD.org (or on =20 multimedia@) about it. Ariff@FreeBSD.org (or multimedia@) can maybe help if you have some =20 questions regarding the drivers in the tree (maybe Ariff will answer =20 to your initial question anyway). Bye, Alexander. --=20 I guess the Little League is even littler than we thought. =09=09-- D. Cavett http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID =3D B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID =3D 72077137
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070710093829.34mqbekao4wwww4s>