Date: Wed, 3 Sep 2014 07:44:16 +0200 From: Antoine Brodin <antoine@freebsd.org> To: Ed Schouten <ed@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r270964 - head/sys/sys Message-ID: <CAALwa8n7gNgrML75eXM3VO9grk8vOBKXPOFdtxpPxKNbBP7cLw@mail.gmail.com> In-Reply-To: <201409021116.s82BGiXI071065@svn.freebsd.org> References: <201409021116.s82BGiXI071065@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Sep 2, 2014 at 1:16 PM, Ed Schouten <ed@freebsd.org> wrote: > Author: ed > Date: Tue Sep 2 11:16:44 2014 > New Revision: 270964 > URL: http://svnweb.freebsd.org/changeset/base/270964 > > Log: > Clean up <sys/cdefs.h> slightly. > > - Remove c++0x hack from <sys/cdefs.h> that was needed when Clang did > not fully implement C++11. We can now safely test against C++11 to > check whether thread_local is available, like we do for all other > C++11 keywords. > > - Don't use __clang__ to test for thread safety annotation presence. It > turns out we have a proper attribute for this. > > Modified: > head/sys/sys/cdefs.h > > Modified: head/sys/sys/cdefs.h > ============================================================================== > --- head/sys/sys/cdefs.h Tue Sep 2 10:35:04 2014 (r270963) > +++ head/sys/sys/cdefs.h Tue Sep 2 11:16:44 2014 (r270964) > @@ -298,8 +298,7 @@ > #endif > > #if !__has_extension(c_thread_local) > -/* XXX: Change this to test against C++11 when clang in base supports it. */ > -#if /* (defined(__cplusplus) && __cplusplus >= 201103L) || */ \ > +#if (defined(__cplusplus) && __cplusplus >= 201103L) || \ > __has_extension(cxx_thread_local) > #define _Thread_local thread_local > #else Hi, This change may break the lang/gcc port on head: http://gohan2.ysv.freebsd.org/data/head-amd64-default-baseline/p367138_s270990/logs/errors/gcc-4.7.4.log Cheers, Antoine
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAALwa8n7gNgrML75eXM3VO9grk8vOBKXPOFdtxpPxKNbBP7cLw>