Date: Mon, 6 Dec 2010 17:00:23 GMT From: John Baldwin <jhb@freebsd.org> To: freebsd-bugs@FreeBSD.org Subject: Re: kern/152768: [mfi] Weird check in mfi(4) Message-ID: <201012061700.oB6H0NSV034600@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/152768; it has been noted by GNATS. From: John Baldwin <jhb@freebsd.org> To: Scott Long <scottl@samsco.org> Cc: bug-followup@freebsd.org, saw@online.de Subject: Re: kern/152768: [mfi] Weird check in mfi(4) Date: Mon, 6 Dec 2010 11:59:38 -0500 On Monday, December 06, 2010 11:45:32 am Scott Long wrote: > John, > > Had a chance to review this, and the patch looks reasonable. This code was basically a copy-and-paste from the aac driver, which will also need a similar change. > > Scott Ok, does this look right for aac? Index: aac_cam.c =================================================================== --- aac_cam.c (revision 216122) +++ aac_cam.c (working copy) @@ -587,7 +587,8 @@ (device == T_PROCESSOR) || (sc->flags & AAC_FLAGS_CAM_PASSONLY)) ccb->csio.data_ptr[0] = - ((device & 0xe0) | T_NODEVICE); + ((ccb->csio.data_ptr[0] & 0xe0) | + T_NODEVICE); } else if (ccb->ccb_h.status == CAM_SEL_TIMEOUT && ccb->ccb_h.target_lun != 0) { /* fix for INQUIRYs on Lun>0 */ -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201012061700.oB6H0NSV034600>