Date: Tue, 23 Jun 2009 23:20:39 GMT From: Prashant Vaibhav <pvaibhav@FreeBSD.org> To: Perforce Change Reviews <perforce@FreeBSD.org> Subject: PERFORCE change 165015 for review Message-ID: <200906232320.n5NNKdDU083903@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=165015 Change 165015 by pvaibhav@pvaibhav_matrix on 2009/06/23 23:19:56 Forgot to include panic fix (mutex must be unlocked in callout_tick() regardless of whether softclock() is to be scheduled or not). Affected files ... .. //depot/projects/soc2009/calloutapi/src/sys/kern/kern_timeout.c#3 edit Differences ... ==== //depot/projects/soc2009/calloutapi/src/sys/kern/kern_timeout.c#3 (text+ko) ==== @@ -259,10 +259,9 @@ * swi_sched acquires the thread lock, so we don't want to call * it with cc_lock held; incorrect locking order. */ - if (need_softclock == 1) { - mtx_unlock_spin_flags(&cc->cc_lock, MTX_QUIET); + mtx_unlock_spin_flags(&cc->cc_lock, MTX_QUIET); + if (need_softclock) swi_sched(cc->cc_cookie, 0); - } } static struct callout_cpu *
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200906232320.n5NNKdDU083903>