Date: Sat, 16 Feb 2013 01:46:47 -0500 From: "Mikhail T." <mi+thun@aldan.algebra.com> To: Ian Lepore <ian@FreeBSD.org> Cc: Tom Evans <tevans.uk@googlemail.com>, Yamaya Takashi <yamayan@kbh.biglobe.ne.jp>, Kimmo Paasiala <kpaasial@gmail.com>, jmg@funkthat.com, Current FreeBSD <freebsd-current@FreeBSD.org>, Ports FreeBSD <freebsd-ports@FreeBSD.org>, "O. Hartmann" <ohartman@zedat.fu-berlin.de> Subject: Re: ports include /etc/src.conf? i.e. graphics/libfpx Message-ID: <511F2B57.8070109@aldan.algebra.com> In-Reply-To: <1360988497.1164.21.camel@revolution.hippie.lan> References: <511B662C.7030602@zedat.fu-berlin.de> <511B874A.7080901@kbh.biglobe.ne.jp> <CAFHbX1Lg4w8g30DrcEbvm%2B6sFvTDpRAt7OouBBBUs1iiMaEL5g@mail.gmail.com> <CA%2B7WWSfOHnYow56BggaG6_T8hGY9GZKTzuT_E7=LWex2Th0XQQ@mail.gmail.com> <511BBDAD.1080806@zedat.fu-berlin.de> <511CD83C.107@aldan.algebra.com> <CAFHbX1LKuDbKYSifFDsRYhc3eCd5g7c-ifAHF9jMSjqow6kVVA@mail.gmail.com> <511CE2AD.8050506@aldan.algebra.com> <CAFHbX1KJ9eDYa4UiZ5N53EEnF1dPmq13F-SvRaKyr=AJYdb79A@mail.gmail.com> <20130214143445.GA5414@straylight.m.ringlet.net> <511EB799.8090401@aldan.algebra.com> <1360973567.1164.13.camel@revolution.hippie.lan> <511F068C.8060503@aldan.algebra.com> <1360988497.1164.21.camel@revolution.hippie.lan>
next in thread | previous in thread | raw e-mail | index | archive | help
15.02.2013 23:21, Ian Lepore ???????(??):
> Since /home/ian/foo/BSDmakefile is not building something that is part
> of the freebsd world, or the freebsd kernel, then according to that
> paragraph, a build using that makefile should not be affected
> by /etc/src.conf.
Maybe it should not be affected. But it is. And the only way to avoid it
is by using an undocumented knob. If the documentation properly
documents the feature, then the implementation of it is faulty.
As suggested earlier, perhaps, the file should only be included, if
something special is put into environment (by /usr/src/Makefile).
Instead it bsd.own.mk currently sucks-in /etc/src.conf by default -- and
one has to set an undocumented flag to avoid that. Something like this
(untested):
Index: Makefile
===================================================================
--- Makefile (revision 246385)
+++ Makefile (working copy)
@@ -293,7 +293,7 @@
# the system bsdmake-like utility to be overridden.
#
MMAKEENV= MAKEOBJDIRPREFIX=${MAKEPATH} \
- DESTDIR= \
+ DESTDIR= _WITH_SRCCONF= \
INSTALL="sh ${.CURDIR}/tools/install.sh"
MMAKE= ${MMAKEENV} ${MAKE} \
-D_UPGRADING \
Index: share/mk/bsd.own.mk
===================================================================
--- share/mk/bsd.own.mk (revision 246385)
+++ share/mk/bsd.own.mk (working copy)
@@ -115,7 +115,7 @@
.if !target(__<bsd.own.mk>__)
__<bsd.own.mk>__:
-.if !defined(_WITHOUT_SRCCONF)
+.if defined(_WITH_SRCCONF)
SRCCONF?= /etc/src.conf
.if exists(${SRCCONF})
.include "${SRCCONF}"
Yours,
-mi
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?511F2B57.8070109>