Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 3 Apr 1997 07:51:44 +0200
From:      j@uriah.heep.sax.de (J Wunsch)
To:        roberto@keltia.freenix.fr (Ollivier Robert)
Cc:        freebsd-bugs@freefall.freebsd.org
Subject:   Re: gnu/3176: `patch' creates files in wrong places (following Index)
Message-ID:  <19970403075144.ZT46473@uriah.heep.sax.de>
In-Reply-To: <19970403015947.46958@keltia.freenix.fr>; from Ollivier Robert on Apr 3, 1997 01:59:47 %2B0200
References:  <199704022200.OAA27937@freefall.freebsd.org> <19970403015947.46958@keltia.freenix.fr>

next in thread | previous in thread | raw e-mail | index | archive | help
As Ollivier Robert wrote:

> Why does our patch(1) apply the -p1 only for *new* files ? There is an
> inconsistency in that.

It doesn't apply -p1 only to new files.

> BTW cvs doesn't use context or unified diffs for its operations so it will
> not see that problem.

Nope.  It's very common to send the output of cvs diff -u somewhere
else for patching.  It's used this way when moving diffs that are
about to be committed to freefall, to avoid clobbering changes that
have been done in the repository by other people.

> Remember that neither Larry's version nor the GNU one has this problem to
> my knowledge (or many people playing with many packages such as Perl5 would
> have discovered before).

This would surprise me mucho.  If you can show an inconsistency
between new and existing files, go ahead.  As the PR stands, it only
proved that Index: lines get precedence over other file names, and
_this_ is a feature.

-- 
cheers, J"org

joerg_wunsch@uriah.heep.sax.de -- http://www.sax.de/~joerg/ -- NIC: JW11-RIPE
Never trust an operating system you don't have sources for. ;-)



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19970403075144.ZT46473>