Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 10 Sep 2000 13:41:13 +0100 (BST)
From:      Doug Rabson <dfr@nlsystems.com>
To:        Peter Wemm <peter@netplex.com.au>
Cc:        Jason Evans <jasone@freebsd.org>, cvs-committers@freebsd.org, cvs-all@freebsd.org
Subject:   Re: cvs commit: src/sys/kern kern_malloc.c 
Message-ID:  <Pine.BSF.4.21.0009101340360.530-100000@salmon.nlsystems.com>
In-Reply-To: <200009100059.e8A0xCG75517@netplex.com.au>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 9 Sep 2000, Peter Wemm wrote:

> Jason Evans wrote:
> > jasone      2000/09/09 15:27:35 PDT
> > 
> >   Modified files:
> >     sys/kern             kern_malloc.c 
> >   Log:
> >   Add a mutex to the malloc interfaces so that it can safely be called
> >   without owning the Giant lock.
> 
> This isn't safe.. It still calls kmem_malloc() which grovels around
> in the VM system.  If you call malloc without Giant, you risk destroying
> the VM system as you would be calling it without Giant held.

The right thing to do here is probably to drop the malloc mutex and take
the the Giant mutex before calling kmem_malloc().

-- 
Doug Rabson				Mail:  dfr@nlsystems.com
Nonlinear Systems Ltd.			Phone: +44 20 8348 3944




To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0009101340360.530-100000>