Date: Sat, 23 Feb 2002 04:28:28 -0800 From: "Crist J. Clark" <cjc@FreeBSD.ORG> To: Ruslan Ermilov <ru@FreeBSD.ORG> Cc: net@FreeBSD.ORG Subject: Re: TCP Connections to a Broadcast Address Message-ID: <20020223042828.E16048@blossom.cjclark.org> In-Reply-To: <20020223115033.GB47437@sunbay.com>; from ru@FreeBSD.ORG on Sat, Feb 23, 2002 at 01:50:33PM %2B0200 References: <20020222022626.A83807@blossom.cjclark.org> <20020223115033.GB47437@sunbay.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Feb 23, 2002 at 01:50:33PM +0200, Ruslan Ermilov wrote:
[snip]
> Nice catch!
Igor M Podlesny <poige@morning.ru>, PR misc/35022, caught it. I just
analyzed it.
[snip]
> The patch is incomplete (see dropwithreset below). Here's the tcp_input.c
> part of the original delta that introduced this bug:
I considered what to do for non-SYN segments, but I didn't see a
requirement in the standards (I may have missed it), so I just didn't
touch it.
> : Script started on Sat Feb 23 13:37:18 2002
> : $ sccs prs -r7.35 tcp_input.c
> : D 7.35 93/04/07 19:28:08 sklower 159 158 00007/00003/01623
> : MRs:
> : COMMENTS:
> : Mostly changes recommended by jch for variable subnets & multiple
> : IP addresses per physical interface. May require further work.
[snip]
> I think you should just back the CSRG revision 7.35 out of tcp_input.c,
> mentioning what was wrong with removing in_broadcast() check.
Where'd you pull this out? I'll integrate this version.
> route add -net 192.168.4 192.168.1.1
> ping 192.168.4.255
>
> on a directly attached 192.168.1 network isn't a "malicious use".
Then I would put that under the "misconfigured" header. The machine
you are pinging from would have to be local to 192.168.4.0/24 also,
why are you routing it through 192.168.1.1? But there may be some
situations that I have not considered where one might wish to do
that.
Anyway, if there are legit configurations where this rears its head,
it is even worse.
--
Crist J. Clark | cjclark@alum.mit.edu
| cjclark@jhu.edu
http://people.freebsd.org/~cjc/ | cjc@freebsd.org
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-net" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020223042828.E16048>