Date: Fri, 17 Oct 2008 13:56:59 +0200 From: Alexander Leidinger <netchild@FreeBSD.org> To: Rink Springer <rink@FreeBSD.org> Cc: Edwin Groothuis <edwin@mavetju.org>, src-committers@FreeBSD.org, svn-src-user@FreeBSD.org Subject: Re: svn commit: r183951 - user/netchild/obsolete/src/libexec/tftpd Message-ID: <20081017135659.41525zeb0tv4avgo@webmail.leidinger.net> In-Reply-To: <20081017111451.GA67097@rink.nu> References: <200810161058.m9GAw0ua059956@svn.freebsd.org> <20081017070044.GC71466@mavetju.org> <20081017112433.24936er2myfi9pwc@webmail.leidinger.net> <20081017105138.GR71453@mavetju.org> <20081017111451.GA67097@rink.nu>
next in thread | previous in thread | raw e-mail | index | archive | help
Quoting Rink Springer <rink@FreeBSD.org> (from Fri, 17 Oct 2008 =20
13:14:51 +0200):
> On Fri, Oct 17, 2008 at 09:51:38PM +1100, Edwin Groothuis wrote:
>> On Fri, Oct 17, 2008 at 11:24:33AM +0200, Alexander Leidinger wrote:
>> > Quoting Edwin Groothuis <edwin@mavetju.org> (from Fri, 17 Oct 2008
>> > 18:00:44 +1100):
>> >
>> > >On Thu, Oct 16, 2008 at 10:58:00AM +0000, Alexander Leidinger wrote:
>> > >> The correct spelling is EACCES, not EACCESS.
>> > >[...]
>> > >>-=09{ EACCESS,=09"Access violation" },
>> > >>+=09{ EACCES,=09"Access violation" },
>> > >
>> > >I am not sure what you mean with this... What is exactly wrong with
>> > >the last S in EACCESS ?
>> >
>> > "man errno" does not list EACCESS, it only lists EACCES.
>>
>> True, but this is a TFTP error, not a system call return value.
>> See also the Appendix "Error Codes" of RFC1350.
>
> Wouldn't using definitions like 'TFTP_Exxx' make more sense, to prevent
> possible confusion as these are TFTP-specific error values?
Boy, this is not only confusing, it's also dangerous. There's more =20
than only the EACCESS very near to named errno values. I fully agree =20
with Rink, specially as the RFC only specifies error values, not =20
symbolic names.
Bye,
Alexander.
--=20
http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID =3D B0063FE7
http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID =3D 72077137
Create problems for which only you have the answer.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20081017135659.41525zeb0tv4avgo>