Date: Mon, 09 Jan 2012 21:25:11 +0100 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> To: Don Lewis <truckman@FreeBSD.org> Cc: current@FreeBSD.org Subject: Re: couldn't log on to my -CURRENT machine after upgrade to latest PAM Message-ID: <86pqesy66w.fsf@ds4.des.no> In-Reply-To: <201201091958.q09JwKZK029815@gw.catspoiler.org> (Don Lewis's message of "Mon, 9 Jan 2012 11:58:20 -0800 (PST)") References: <201201091958.q09JwKZK029815@gw.catspoiler.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Don Lewis <truckman@FreeBSD.org> writes: > After staring at the code a lot more, I see your point about the loss of > information. The problem is that openpam_parse_chain() returns > PAM_SUCCESS whether or not if found anything, but we want the loop to > terminate when either an error is detected or if openpam_parse_chain() > actually found something. Maybe changing the loop exit to something > like this would work: > > if (ret !=3D PAM_SUCCESS || pamh->chains[facility] !=3D NULL) > return (ret); The simplest fix for now is probably to revert r487; it applies cleanly except for the first hunk, which is easy to apply manually. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86pqesy66w.fsf>