Date: Tue, 01 Nov 2016 16:49:36 +0100 From: Harry Schmalzbauer <freebsd@omnilan.de> To: John Baldwin <jhb@freebsd.org> Cc: svn-src-all@freebsd.org Subject: Re: svn commit: r297568 - head/sys/dev/fdc Message-ID: <5818B990.2010400@omnilan.de> In-Reply-To: <201604050008.u3508gWj068936@repo.freebsd.org> References: <201604050008.u3508gWj068936@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Bezüglich John Baldwin's Nachricht vom 05.04.2016 02:08 (localtime): > Author: jhb > Date: Tue Apr 5 00:08:42 2016 > New Revision: 297568 > URL: https://svnweb.freebsd.org/changeset/base/297568 > > Log: > Don't wakeup the fdc worker thread once a second when idle. > > The fdc worker thread was using a one second timeout while waiting for > a new bio to arrive or for the device to detach. However, the driver > already does a wakeup when queueing a new bio or asking the thread to > detach, so the timeout only served to waste CPU time waking up the > thread once a second just so it could go right back to sleep. Use an > infinite timeout instead. > > Discussed with: phk > Sponsored by: Netflix Imho that was nice to have in 10.4. Any reason not to MFS? Thanks, -harry
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5818B990.2010400>