Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 09 Apr 2016 08:27:27 -0700
From:      John Baldwin <jhb@freebsd.org>
To:        Konstantin Belousov <kostikbel@gmail.com>
Cc:        Wolfgang Zenker <wolfgang@lyxys.ka.sub.org>, freebsd-current@freebsd.org, freebsd@grem.de
Subject:   Re: Acer C720 crash at boot
Message-ID:  <1560530.UPOY1Ni5U9@ralph.baldwin.cx>
In-Reply-To: <20160409142535.GP1741@kib.kiev.ua>
References:  <20160409121004.GA69051@lyxys.ka.sub.org> <20160409132746.GA69968@lyxys.ka.sub.org> <20160409142535.GP1741@kib.kiev.ua>

next in thread | previous in thread | raw e-mail | index | archive | help
On Saturday, April 09, 2016 05:25:35 PM Konstantin Belousov wrote:
> On Sat, Apr 09, 2016 at 03:27:46PM +0200, Wolfgang Zenker wrote:
> > Done: http://cid2945g797.hs14.hosting.punkt.de/IMG_3762.JPG
> 
> The immediate cause was the change in r297466, but the code that existed
> there, did not worked.  It looks as a bug in ichiic, set_controller()
> use msleep() with timeout too early when compiled into the kernel.

Can you try this change:

diff --git a/sys/dev/ichiic/ig4_iic.c b/sys/dev/ichiic/ig4_iic.c
index a556127..23bdb7d 100644
--- a/sys/dev/ichiic/ig4_iic.c
+++ b/sys/dev/ichiic/ig4_iic.c
@@ -117,7 +117,10 @@ set_controller(ig4iic_softc_t *sc, uint32_t ctl)
 			error = 0;
 			break;
 		}
-		mtx_sleep(sc, &sc->io_lock, 0, "i2cslv", 1);
+		if (cold)
+			DELAY(1000);
+		else
+			mtx_sleep(sc, &sc->io_lock, 0, "i2cslv", 1);
 	}
 	return (error);
 }


-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1560530.UPOY1Ni5U9>