Date: Sat, 04 Mar 2006 15:42:13 +0200 From: Andriy Gapon <avg@icyb.net.ua> To: Dirk Meyer <dirk.meyer@dinoex.sub.org> Cc: danfe@freebsd.org, freebsd-ports@freebsd.org Subject: Re: GNUSTEP_PREFIX not in bsd.gnustep.mk ? Message-ID: <44099935.6040205@icyb.net.ua> In-Reply-To: <7397fGT8Ff@dmeyer.dinoex.sub.org> References: <43FEFD30.2080605@icyb.net.ua> <7397fGT8Ff@dmeyer.dinoex.sub.org>
next in thread | previous in thread | raw e-mail | index | archive | help
on 04/03/2006 11:02 Dirk Meyer said the following:
> Andriy Gapon schrieb:,
>> Wouldn't it be reasonable to define some default value for this variable
>> in ports/Mk/bsd.gnustep.mk ? For example many ports have to have the
>> following line now:
>> GNUSTEP_PREFIX?=${LOCALBASE}/GNUstep
>> (please note ?= operator)
>
> No. This changes where for some reason,
> they allows ports like ruby-gnustep and others bindings
> to use bsd.gnustep.mk with the default prefix.
I don't get it. devel/ruby-gnustep/Makefile has:
GNUSTEP_PREFIX?= ${LOCALBASE}/GNUstep
Also:
$ glimpse -l GNUSTEP_PREFIX > gpref.lst
$ glimpse -l USE_GNUSTEP > gstep.lst
$ diff -U 0 gpref.lst gstep.lst
--- gpref.lst Sat Mar 4 15:31:04 2006
+++ gstep.lst Sat Mar 4 15:31:23 2006
@@ -1,0 +2,1 @@
+/usr/ports/Mk/bsd.port.mk
@@ -3,0 +6 @@
+/usr/ports/devel/portmk/Mk/bsd.port.mk
@@ -27,0 +31,3 @@
+/usr/ports/Tools/scripts/portsvar.sh
+/usr/ports/games/oolite/Makefile
+/usr/ports/graphics/cenon/Makefile
Also:
$ glimpse -h 'GNUSTEP_PREFIX.*=' | sort -u
GNUSTEP_PREFIX?= ${LOCALBASE}/GNUstep
MAKE_ARGS+= GNUSTEP_PREFIX=${PREFIX}/System
This basically means that every port depending on GNUstep (except for
those two that were originally missed) has
GNUSTEP_PREFIX?= ${LOCALBASE}/GNUstep
line in its Makefile.
So, I'd like to suggest again to put this line into bsd.gnustep.mk,
instead of having it in each of the ports in question.
Did I misunderstood or misinterpret something ?
--
Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?44099935.6040205>