Date: Sun, 31 Aug 2014 09:50:59 +0200 From: Kurt Jaeger <lists@opsec.eu> To: Ted Faber <faber@lunabase.org> Cc: freebsd-ports@freebsd.org Subject: Re: How to submit a port update? Message-ID: <20140831075059.GW9400@home.opsec.eu> In-Reply-To: <540250CF.5010803@lunabase.org> References: <5401F646.6030304@lunabase.org> <20140830175001.GS9400@home.opsec.eu> <54023CF9.1040002@lunabase.org> <20140830212321.GV9400@home.opsec.eu> <540250CF.5010803@lunabase.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi! > The update is mostly some small changes to the code to eliminate clang++ > and recent g++ warnings along with Eric's typo, which has been > languishing for a while. I know it's a small thing, but seeing those > warnings when I compile the port makes me sad. Obviously you guys can > reject if you don't feel it's worth it. Well, it's always nice to check process and procedures while it's not time-critical 8-} And you are right, the porters handbook still mentions send-pr. There is one thing which is very nice to have for an incoming PR: poudriere test logs that prove that the updated port builds cleanly. If you never used poudriere, have a look at this short starter guide: https://fossil.etoilebsd.net/poudriere/doc/trunk/doc/using_testport.wiki > That changes the port diff, of course. The new one is attached, or I > can update bugzilla. Always update bugzilla (says the guy who preferres mail...) > Sorry to bug you if it's too trivial a change. No, it's fine. I guess I would only release new versions if runtime bugs or runtime functionality changes. You also updated the autotools environment, maybe that fixes other stuff as well. You re-rolled the distfile without a version change, this is not purrrfect, but well, what else is 8-) -- pi@opsec.eu +49 171 3101372 6 years to go !
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140831075059.GW9400>