Date: Mon, 10 Mar 2014 17:53:51 -0400 From: Julio Merino <jmmv@freebsd.org> To: Garrett Cooper <yaneurabeya@gmail.com> Cc: "freebsd-testing@freebsd.org" <freebsd-testing@freebsd.org>, Pawel Jakub Dawidek <pjd@freebsd.org> Subject: Re: [PATCH] Integrate pjdfstest into the build Message-ID: <CAFY7cWDHYtAi7EbVjQ=q7xdEYc3sZeojLe9=7i00iTv%2BQo81rg@mail.gmail.com> In-Reply-To: <CAGHfRMB4eOBFvyCk517hLNwJK3K9nfWzjCN6dwF5W4cOkOVeXw@mail.gmail.com> References: <94D3F60A-1E12-418B-8313-E43C93878B95@gmail.com> <CAFY7cWDsR=82ANK8q2-SoVyu6BowdC6hHDwo%2Bs1P7Jt%2Bfy8ZCQ@mail.gmail.com> <56D809A7-5387-475A-8C89-794E328F6935@gmail.com> <CAFY7cWCme4QTbo86uQhJ_DFLb9Z6dfWaj_%2Bs9m-tWFw35Vx%2BAQ@mail.gmail.com> <CAGHfRMB4eOBFvyCk517hLNwJK3K9nfWzjCN6dwF5W4cOkOVeXw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Mar 3, 2014 at 1:22 PM, Garrett Cooper <yaneurabeya@gmail.com> wrote: > On Sun, Mar 2, 2014 at 3:00 PM, Julio Merino <jmmv@freebsd.org> wrote: >> Then I believe this should really live under contrib/pjdfstest. Any >> reason it's not there? If it's external, then yes, we should keep the >> layout of the upstream sources without performing any renames (unless >> Pawel wants to do them). > > I think it should be, but I don't own pjdfstest ;).. > (largely for jmmv's benefit) Ultimately if pjd went this route, > pjdfstest needs to be put in the vendor repo, reimported into FreeBSD > under contrib, and then linked into the tree appropriately. pjd and I discussed this over IRC and he says that this is fine as long as the main structure of pjdfstest is maintained. Ensuring the structure is, arguably, the whole point of putting the code into contrib so this is not a problem. So, we should: 1. Import pjdfstest under a vendor repository. 2. Merge pjdfstest into contrib/pjdfstest/. 3. Add reachover Makefiles and the configuration file somewhere under tests/sys/ (?). 4. Remove all of tools/regression/pjdfstest/. 5. Plug into the test suite! I'll put this in my to-do queue so, eventually, I will get to it... but if any of you can do so instead the better :-)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFY7cWDHYtAi7EbVjQ=q7xdEYc3sZeojLe9=7i00iTv%2BQo81rg>